Fix memory corruption issue #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased #1.
xiaowei-guan
approved these changes
Nov 26, 2020
swift-kim
added a commit
that referenced
this pull request
Feb 15, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Feb 15, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Mar 10, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Jun 7, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
bbrto21
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Enable x64(pc) build for tizen shell
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Use enable_desktop_embeddings instead of embedder_for_pc
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
Add flutter_tizen_engine TC
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add basic shell for test
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Introduce mock_engine for unittest
* copied from linux port ('/shell/platform/linux/testing/mock_engine.cc')
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Code clean-up && Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add EvasGL Helper for x64 shell build
* This file is the same file as Evas_GL_GLES3_Helpers.h in tizen.
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Fix minor thing
* Change ecore lib path at X64 shell
* Refactor log function dummy
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Add stubs for LocalizationChannel and PlatformChannel
* Add SettingsChannel stub
* Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies
* Fix minor thing
* Add log stub
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
bbrto21
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Enable x64(pc) build for tizen shell
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Use enable_desktop_embeddings instead of embedder_for_pc
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
Add flutter_tizen_engine TC
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add basic shell for test
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Introduce mock_engine for unittest
* copied from linux port ('/shell/platform/linux/testing/mock_engine.cc')
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Code clean-up && Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add EvasGL Helper for x64 shell build
* This file is the same file as Evas_GL_GLES3_Helpers.h in tizen.
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Fix minor thing
* Change ecore lib path at X64 shell
* Refactor log function dummy
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Add stubs for LocalizationChannel and PlatformChannel
* Add SettingsChannel stub
* Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies
* Fix minor thing
* Add log stub
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Enable x64(pc) build for tizen shell
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Use enable_desktop_embeddings instead of embedder_for_pc
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
Add flutter_tizen_engine TC
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add basic shell for test
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Introduce mock_engine for unittest
* copied from linux port ('/shell/platform/linux/testing/mock_engine.cc')
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Code clean-up && Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add EvasGL Helper for x64 shell build
* This file is the same file as Evas_GL_GLES3_Helpers.h in tizen.
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Fix minor thing
* Change ecore lib path at X64 shell
* Refactor log function dummy
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Add stubs for LocalizationChannel and PlatformChannel
* Add SettingsChannel stub
* Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies
* Fix minor thing
* Add log stub
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Enable x64(pc) build for tizen shell
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Use enable_desktop_embeddings instead of embedder_for_pc
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
Add flutter_tizen_engine TC
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add basic shell for test
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Introduce mock_engine for unittest
* copied from linux port ('/shell/platform/linux/testing/mock_engine.cc')
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Code clean-up && Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Clean up shell/platform/tizen/BUILD.gn #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Add EvasGL Helper for x64 shell build
* This file is the same file as Evas_GL_GLES3_Helpers.h in tizen.
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Fix minor thing
* Change ecore lib path at X64 shell
* Refactor log function dummy
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Add stubs for LocalizationChannel and PlatformChannel
* Add SettingsChannel stub
* Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies
* Fix minor thing
* Add log stub
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* Apply review's comment #2
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Co-authored-by: Swift Kim <swift.kim@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Improves test failure messages when matching FlValue arguments. For example, before: Expected arg #2: has setting ("platformBrightness", 0x32f0980) Actual: 0x7f81ec005990, 0x32f0900 And after: Expected arg #2: has setting ("platformBrightness", dark) Actual: 0x27bded0, {textScaleFactor: 0.0, alwaysUse24HourFormat: false, platformBrightness: light}
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 4, 2023
…visions) (flutter#43457)" (flutter#43466) This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll. From flutter/flutter#130138: _TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)) ``` #0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53) #1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23) #3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54) #5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #6 ListIterable.forEach (dart:_internal/iterable.dart:39:13) #7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16) #8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8) #9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27) #10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5) #11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59) #12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60) #13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15) <asynchronous suspension> #14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5) <asynchronous suspension> #15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5) <asynchronous suspension> #16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27) <asynchronous suspension> #17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19) <asynchronous suspension> #18 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> ```
JSUYA
pushed a commit
that referenced
this pull request
Mar 18, 2024
This relands flutter#43620 with a fix for nested tappable nodes. The first PR introduced this regression: flutter/flutter#134842. This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework. Fixes flutter/flutter#134842
JSUYA
pushed a commit
to JSUYA/engine
that referenced
this pull request
Aug 23, 2024
The culprit test asks different threads to access some stack variables, but the stack might return earlier than the threads' completion. This PR fixes it by adding latches.
This test, despite being possibly fine for now, consistently triggers the following asan error when I make some unrelated trivial changes.
The thrown error:
<details>
<pre>
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EmbedderTest
[ RUN ] EmbedderTest.EmbedderThreadHostUseCustomThreadConfig
=================================================================
==14398==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00031833b530 at pc 0x00013248d543 bp 0x000318740390 sp 0x00031873fb58
WRITE of size 4 at 0x00031833b530 thread T2
#0 0x13248d542 in pthread_getschedparam+0x3d2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542)
flutter-tizen#1 0x100577671 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0::operator()() const+0x1a1 (embedder_unittests:x86_64+0x10030b671)
flutter-tizen#2 0x1005774a2 in decltype(std::declval<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>()()) std::_fl::__invoke[abi:v15000]<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b4a2)
flutter-tizen#3 0x100577402 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b402)
flutter-tizen#4 0x1005773ba in std::_fl::__function::__alloc_func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x10030b3ba)
flutter-tizen#5 0x1005734f6 in std::_fl::__function::__func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x1003074f6)
flutter-tizen#6 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
flutter-tizen#7 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
flutter-tizen#8 0x100c229dc in fml::MessageLoopImpl::FlushTasks(fml::FlushType)+0x37c (embedder_unittests:x86_64+0x1009b69dc)
flutter-tizen#9 0x100c22577 in fml::MessageLoopImpl::RunExpiredTasksNow()+0x27 (embedder_unittests:x86_64+0x1009b6577)
flutter-tizen#10 0x100c8aa2f in fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)+0x2f (embedder_unittests:x86_64+0x100a1ea2f)
flutter-tizen#11 0x7ff817b54508 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__+0x13 (CoreFoundation:x86_64+0x97508)
flutter-tizen#12 0x7ff817b540b8 in __CFRunLoopDoTimer+0x310 (CoreFoundation:x86_64+0x970b8)
flutter-tizen#13 0x7ff817b53ce9 in __CFRunLoopDoTimers+0x11c (CoreFoundation:x86_64+0x96ce9)
flutter-tizen#14 0x7ff817b380ac in __CFRunLoopRun+0x83b (CoreFoundation:x86_64+0x7b0ac)
flutter-tizen#15 0x7ff817b372a8 in CFRunLoopRunSpecific+0x22c (CoreFoundation:x86_64+0x7a2a8)
flutter-tizen#16 0x100c8b155 in fml::MessageLoopDarwin::Run()+0x305 (embedder_unittests:x86_64+0x100a1f155)
flutter-tizen#17 0x100c223d0 in fml::MessageLoopImpl::DoRun()+0x150 (embedder_unittests:x86_64+0x1009b63d0)
flutter-tizen#18 0x100c1f1fa in fml::MessageLoop::Run()+0x2a (embedder_unittests:x86_64+0x1009b31fa)
flutter-tizen#19 0x100c7baa4 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0::operator()() const+0x194 (embedder_unittests:x86_64+0x100a0faa4)
flutter-tizen#20 0x100c7b8e2 in decltype(std::declval<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>()()) std::_fl::__invoke[abi:v15000]<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f8e2)
flutter-tizen#21 0x100c7b842 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f842)
flutter-tizen#22 0x100c7b7fa in std::_fl::__function::__alloc_func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x100a0f7fa)
flutter-tizen#23 0x100c77ad6 in std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x100a0bad6)
flutter-tizen#24 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
flutter-tizen#25 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
flutter-tizen#26 0x100c75388 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::operator()(void*) const+0xe8 (embedder_unittests:x86_64+0x100a09388)
flutter-tizen#27 0x100c75227 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+0xc7 (embedder_unittests:x86_64+0x100a09227)
flutter-tizen#28 0x1324b3e76 in asan_thread_start(void*)+0x46 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x52e76)
flutter-tizen#29 0x7ff817a5c18a in _pthread_start+0x62 (libsystem_pthread.dylib:x86_64+0x618a)
flutter-tizen#30 0x7ff817a57ae2 in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x1ae2)
Address 0x00031833b530 is located in stack of thread T0 at offset 144 in frame
#0 0x1002d051f in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0xf (embedder_unittests:x86_64+0x10006451f)
This frame has 12 object(s):
[32, 40) 'thread_host' (line 3445)
[64, 112) 'ref.tmp' (line 3446)
[144, 148) 'ui_policy' (line 3449) <== Memory access at offset 144 is inside this variable
[160, 168) 'ui_param' (line 3450)
[192, 200) 'ref.tmp2' (line 3452)
[224, 272) 'ref.tmp5' (line 3452)
[304, 320) 'agg.tmp'
[336, 340) 'io_policy' (line 3458)
[352, 360) 'io_param' (line 3459)
[384, 392) 'ref.tmp6' (line 3460)
[416, 464) 'ref.tmp10' (line 3460)
[496, 512) 'agg.tmp11'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-use-after-scope (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542) in pthread_getschedparam+0x3d2
Shadow bytes around the buggy address:
0x00031833b280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b480: 00 00 00 00 f1 f1 f1 f1 00 f2 f2 f2 f8 f8 f8 f8
=>0x00031833b500: f8 f8 f2 f2 f2 f2[f8]f2 f8 f2 f2 f2 f8 f2 f2 f2
0x00031833b580: f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 00 00 f2 f2 f8 f2
0x00031833b600: f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 f8 f8 f2 f2
0x00031833b680: f2 f2 00 00 f3 f3 f3 f3 00 00 00 00 00 00 00 00
0x00031833b700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x00031833b780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
Thread T2 created by T0 here:
#0 0x1324ae92d in pthread_create+0x5d (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x4d92d)
flutter-tizen#1 0x100c73901 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x401 (embedder_unittests:x86_64+0x100a07901)
flutter-tizen#2 0x100c73cca in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x2a (embedder_unittests:x86_64+0x100a07cca)
flutter-tizen#3 0x100c748c9 in std::_fl::__unique_if<fml::ThreadHandle>::__unique_single std::_fl::make_unique[abi:v15000]<fml::ThreadHandle, fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&&)+0x149 (embedder_unittests:x86_64+0x100a088c9)
flutter-tizen#4 0x100c74335 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x255 (embedder_unittests:x86_64+0x100a08335)
flutter-tizen#5 0x100c746b2 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x32 (embedder_unittests:x86_64+0x100a086b2)
flutter-tizen#6 0x106ee0b1a in std::_fl::__unique_if<fml::Thread>::__unique_single std::_fl::make_unique[abi:v15000]<fml::Thread, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&>(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&)+0x4a (embedder_unittests:x86_64+0x106c74b1a)
flutter-tizen#7 0x106ee08e8 in flutter::ThreadHost::CreateThread(flutter::ThreadHost::Type, std::_fl::optional<fml::Thread::ThreadConfig>, flutter::ThreadHost::ThreadHostConfig const&) const+0x1b8 (embedder_unittests:x86_64+0x106c748e8)
flutter-tizen#8 0x106ee1466 in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2f6 (embedder_unittests:x86_64+0x106c75466)
flutter-tizen#9 0x106ee19ca in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2a (embedder_unittests:x86_64+0x106c759ca)
flutter-tizen#10 0x100b6f730 in flutter::EmbedderThreadHost::CreateEngineManagedThreadHost(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0x3a0 (embedder_unittests:x86_64+0x100903730)
flutter-tizen#11 0x100b6e51c in flutter::EmbedderThreadHost::CreateEmbedderOrEngineManagedThreadHost(FlutterCustomTaskRunners const*, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0xcc (embedder_unittests:x86_64+0x10090251c)
flutter-tizen#12 0x1002d0748 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0x238 (embedder_unittests:x86_64+0x100064748)
flutter-tizen#13 0x1089ce93b in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10876293b)
flutter-tizen#14 0x108955bdf in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x2cf (embedder_unittests:x86_64+0x1086e9bdf)
flutter-tizen#15 0x108955755 in testing::Test::Run()+0x3a5 (embedder_unittests:x86_64+0x1086e9755)
flutter-tizen#16 0x108957b23 in testing::TestInfo::Run()+0x593 (embedder_unittests:x86_64+0x1086ebb23)
flutter-tizen#17 0x10895a8f2 in testing::TestSuite::Run()+0x6e2 (embedder_unittests:x86_64+0x1086ee8f2)
flutter-tizen#18 0x108977d7a in testing::internal::UnitTestImpl::RunAllTests()+0xb9a (embedder_unittests:x86_64+0x10870bd7a)
flutter-tizen#19 0x1089ee88b in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10878288b)
flutter-tizen#20 0x1089770ac in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x2cc (embedder_unittests:x86_64+0x10870b0ac)
flutter-tizen#21 0x108976c3b in testing::UnitTest::Run()+0x28b (embedder_unittests:x86_64+0x10870ac3b)
flutter-tizen#22 0x1083e45e2 in RUN_ALL_TESTS()+0x22 (embedder_unittests:x86_64+0x1081785e2)
flutter-tizen#23 0x1083e43c8 in main+0x6e8 (embedder_unittests:x86_64+0x1081783c8)
flutter-tizen#24 0x213ff0365 (<unknown module>)
==14398==ABORTING
[1] 14398 abort ../out/host_debug_unopt/embedder_unittests
</pre>
</details>
The changes I made (isolated from a larger change, therefore it doesn't seem reasonable by itself):
```diff
// shell/common/platform_view.cc, L33
void PlatformView::DispatchPointerDataPacket(
std::unique_ptr<PointerDataPacket> packet) {
- delegate_.OnPlatformViewDispatchPointerDataPacket(
- pointer_data_packet_converter_.Convert(std::move(packet)));
+ delegate_.OnPlatformViewDispatchPointerDataPacket(std::move(packet));
}
```
Base engine rev: de2a73c
Environment: Macbook with M1 Max Chip, OS 14.4.1
Compiling with:
```
./engine/src/flutter/tools/gn --goma --unoptimized --asan --xcode-symlinks
./depot_tools/ninja -j200 -C ./engine/src/out/host_debug_unopt
./out/host_debug_unopt/embedder_unittests
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #1.